Skip to content

Fix error judgement for MainFragmentLocatedRegion and MostlyUsedDataRegion in distributed plan#11636

Merged
JackieTien97 merged 1 commit intomasterfrom
beyyes/fix_timeout
Nov 29, 2023
Merged

Fix error judgement for MainFragmentLocatedRegion and MostlyUsedDataRegion in distributed plan#11636
JackieTien97 merged 1 commit intomasterfrom
beyyes/fix_timeout

Conversation

@Beyyes
Copy link
Member

@Beyyes Beyyes commented Nov 29, 2023

Description

The previous judgement of in ExchangeNodeAdder.java may be wrong, because MostlyUsedDataRegion may be ahead of MainFragmentLocatedRegion.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (bb20b5f) 49.01% compared to head (7e8ddd8) 49.02%.
Report is 2 commits behind head on master.

Files Patch % Lines
...e/plan/planner/distribution/ExchangeNodeAdder.java 35.29% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11636   +/-   ##
=========================================
  Coverage     49.01%   49.02%           
- Complexity    24898    24904    +6     
=========================================
  Files          2815     2815           
  Lines        176117   176128   +11     
  Branches      21125    21129    +4     
=========================================
+ Hits          86322    86342   +20     
+ Misses        89795    89786    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit 431e9b8 into master Nov 29, 2023
@JackieTien97 JackieTien97 deleted the beyyes/fix_timeout branch November 29, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants